loader: Lazily allocate ICD surface objects #1659
Conversation
|
CI Vulkan-Loader build queued with queue ID 374508. |
|
CI Vulkan-Loader build queued with queue ID 374525. |
|
CI Vulkan-Loader build # 2918 running. |
|
CI Vulkan-Loader build # 2918 passed. |
There was a problem hiding this comment.
After a first review, my impression is that this 1. cleans the code up nicely and 2. the wsi code should really be generated.
As far as pNext chains go, there shouldn't be any unknown types due to the Loader preventing any unknown instance level extensions from being enabled. This can be disabled, but the policy prevents the common situation of "new instance level extension silently breaks code" by forcing a new loader to be used.
There is a new codegen feature in town with the latest header update, vulkan_object.py.
I would hold off doing any major changes to the code gen due so that the new (much better!) code gen can be used instead, which should be much easier to use and less "oh dear god". I can work on it shortly but am happy to review any codgen related changes you make. Wanted to establish who's doing what so nobody does work unnecessarily.
Fixes #1541.
This is marked as draft, because there are some open questions:
sTypeof surface create infos were not set before and now the new code expects correct input, not invalid (due to the create info copies). I hope that's okay.